Concrete Routes Don't Allow Optional Values

Question

Concrete Routes Don't Allow Optional Values

JamesCoonce opened this issue 6 years ago · comments

I ran into the issue of trying to create a customer with only an email and description. Normally most parameters are optional. This is true in the Model and also in the protocol for CustomerRoutes.swift. The issue lies in the fact that the implementation StripeCustomerRoutes doesn't set the optional values to = nil like the extension of the protocol. This causes the parameter to be required or else you will receive an error to the one bellow.

error: missing argument for parameter 'accountBalance' in call
            let stripeCustomer = try client.customer.create(email: customer.email, description: customer.description)
                                                            ^
                                                            accountBalance: <#Int?#>,
Stripe.CustomerRoutes:2:17: note: 'create(accountBalance:businessVatId:coupon:defaultSource:description:email:metadata:shipping:source:)' declared here

Andrew Edwards · Answer 1 · Sun Oct 07 2018 04:50:30 GMT+0800 (China Standard Time)

That shouldn’t be the case and works fine for me. Even in my test cases. If you look at Provider.swiftall of the route properties are using the protocol type rather than the concrete type. So those default implementations with nil being the default value should work fine.

Andrew Edwards · Answer 2 · Sun Oct 07 2018 04:55:46 GMT+0800 (China Standard Time)

This compiles fine for me

let stripe = try req.make(StripeClient.self)
return try stripe.customer.create(email: registration.email).flatMap { customer in

JamesCoonce · Answer 3 · Sun Oct 07 2018 05:01:59 GMT+0800 (China Standard Time)

Hmmmm. That's strange

func create(_ req: Request) throws -> Future<Customer> {
        let stripe = try req.make(StripeClient.self)
        return try req.content.decode(Customer.self).flatMap(to: Customer.self) { customer in
            let stripeCustomer = try stripe.customer.create(email: customer.email, description: customer.description)
            customer.stripeId = stripeCustomer.id
            return customer.save(on: req)
        }
    }


/Users/jamescoonce/SwiftWeb/StripeCustomer/Sources/App/Controllers/CustomersController.swift:21:61: error: m
issing argument for parameter 'accountBalance' in call
            let stripeCustomer = try stripe.customer.create(email: customer.email, description: customer.des
cription)
                                                            ^
                                                            accountBalance: <#Int?#>,
Stripe.CustomerRoutes:2:17: note: 'create(accountBalance:businessVatId:coupon:defaultSource:description:email:metadata:shipping:source:)' declared here
    public func create(accountBalance: Int?, businessVatId: String?, coupon: String?, defaultSource: String?, description: String?, email: String?, metadata: [String : String]?, shipping: Stripe.ShippingLabel?, source: Any?) throws -> NIO.EventLoopFuture<Stripe.StripeCustomer>

Andrew Edwards · Answer 4 · Sun Oct 07 2018 05:03:26 GMT+0800 (China Standard Time)

You sure you have the latest version of the provider?

JamesCoonce · Answer 5 · Sun Oct 07 2018 05:06:32 GMT+0800 (China Standard Time)

.package(url: "https://github.com/vapor-community/stripe-provider.git", from: "2.2.0"),

Andrew Edwards · Answer 6 · Sun Oct 07 2018 05:16:59 GMT+0800 (China Standard Time)

That's interesting. I have no idea why you're getting a compile error. Get rid of the build folder, delete Package.resolved and try to do a package update. Maybe you have a really old version still.

Andrew Edwards · Answer 7 · Sun Oct 07 2018 05:32:49 GMT+0800 (China Standard Time)

A new version of the provider was just released also. Although those changes were in previous release try the latest and see if that helps 2.2.1
https://github.com/vapor-community/stripe-provider/releases/tag/2.2.1

JamesCoonce · Answer 8 · Sun Oct 07 2018 06:23:16 GMT+0800 (China Standard Time)

.package(url: "https://github.com/vapor-community/stripe-provider.git", from: "2.2.1"),

In Package.resolved

{
        "package": "Stripe",
        "repositoryURL": "https://github.com/vapor-community/stripe-provider.git",
        "state": {
          "branch": null,
          "revision": "20c35dabd901c02bc7ad5fffd47f7a8e34595cbc",
          "version": "2.2.1"
        }
      },

.build was also delete

This is the output.


/Users/jamescoonce/SwiftWeb/StripeCustomer/Sources/App/Controllers/CustomersController.swift:21:61: error: missing argument for parameter 'accountBalance' in call
            let stripeCustomer = try stripe.customer.create(email: customer.email, description: customer.description)
                                                            ^
                                                            accountBalance: <#Int?#>,
Stripe.CustomerRoutes:2:17: note: 'create(accountBalance:businessVatId:coupon:defaultSource:description:email:metadata:shipping:source:)' declared here
    public func create(accountBalance: Int?, businessVatId: String?, coupon: String?, defaultSource: String?, description: String?, email: String?, metadata: [String : String]?, shipping: Stripe.ShippingLabel?, source: Any?) throws -> NIO.EventLoopFuture<Stripe.StripeCustomer>
                ^

Andrew Edwards · Answer 9 · Thu Oct 11 2018 01:54:02 GMT+0800 (China Standard Time)

Where you able to figure this out? I don’t think anyone else has had this problem.