`./testsuite` does not support `--jobs` under OpenBSD

[Charles Daniels]

The generated testsuite file does not support an --jobs flag under OpenBSD. Consider the terminal session below as an example.

Simply setting TESTSUITEFLAGS = appears to resolve this issue.

Tested under OpenBSD 6.4 on an AMD64 based system.

cad@nessus:~/D/pcalc > gmake MAKE=gmake check test
cc -ggdb -Wall -DVERSION='"4"'  -c -o pcalc.o pcalc.c
cc -ggdb -Wall -DVERSION='"4"'  -c -o pcalcl.o pcalcl.c
pcalcl.c:1705:17: warning: unused function 'yyunput' [-Wunused-function]
    static void yyunput (int c, char * yy_bp )
                ^
pcalcl.c:1746:16: warning: function 'input' is not needed and will not be emitted
      [-Wunneeded-internal-declaration]
    static int input  (void)
               ^
2 warnings generated.
cc -ggdb -Wall -DVERSION='"4"'  -c -o funct.o funct.c
cc -ggdb -Wall -DVERSION='"4"'  -c -o math.o math.c
cc -ggdb -Wall -DVERSION='"4"'  -c -o symbol.o symbol.c
cc -ggdb -Wall -DVERSION='"4"'  -c -o help.o help.c
cc -ggdb -Wall -DVERSION='"4"'  -c -o store.o store.c
cc -ggdb -Wall -DVERSION='"4"'  -c -o print.o print.c
cc -ggdb -Wall -DVERSION='"4"'  -c -o str.o str.c
cc -ggdb -Wall -DVERSION='"4"'  -c -o convert.o convert.c
cc -ggdb -Wall  pcalc.o pcalcl.o funct.o math.o symbol.o help.o store.o print.o str.o con
ert.o  -lm -lfl -o pcalc
symbol.o: In function `install_sym':
/home/cad/Downloads/pcalc/symbol.c:171: warning: strcpy() is almost always misused, pleas
 use strlcpy()
store.o: In function `store':
/home/cad/Downloads/pcalc/store.c:93: warning: sprintf() is often misused, please use snp
intf()
gmake -C ptest check
gmake[1]: Entering directory '/home/cad/Downloads/pcalc/ptest'
./testsuite --jobs=`getconf _NPROCESSORS_ONLN || echo 1`
getconf: _NPROCESSORS_ONLN: unknown variable
testsuite: error: invalid variable name: --jobs
gmake[1]: *** [Makefile:39: check] Error 1
gmake[1]: Leaving directory '/home/cad/Downloads/pcalc/ptest'
gmake: *** [Makefile:39: check] Error 2
cad@nessus:~/D/pcalc > ./ptest/testsuite --help
Usage: ./ptest/testsuite [OPTION]... [VARIABLE=VALUE]... [TESTS]

Run all the tests, or the selected TESTS, and save a detailed log file.
Upon failure, create debugging scripts.

You should not change environment variables unless explicitly passed
as command line arguments.  Set `AUTOTEST_PATH' to select the executables
to exercise.  Each relative directory is expanded as build and source
directories relatively to the top level of this distribution.  E.g.,

  $ ./ptest/testsuite AUTOTEST_PATH=bin

possibly amounts into

  PATH=/tmp/foo-1.0/bin:/src/foo-1.0/bin:$PATH

Operation modes:
  -h, --help     print the help message, then exit
  -V, --version  print version number, then exit
  -c, --clean    remove all the files this test suite might create and exit
  -l, --list     describes all the tests, or the selected TESTS

Execution tuning:
  -k, --keywords=KEYWORDS
                 select the tests matching all the comma separated KEYWORDS
                 accumulates
  -e, --errexit  abort as soon as a test fails; implies --debug
  -v, --verbose  force more detailed output
                 default for debugging scripts
  -d, --debug    inhibit clean up and debug script creation
                 default for debugging scripts
  -x, --trace    enable tests shell tracing

Report bugs to <https://github.com/vapier/pcalc/issues>.

[Mike Frysinger]

i suspect the issue is that your autoconf is too old. --jobs was added with the autoconf-2.64 release. considering 2.64 was released in July 2009, i have no intention in supporting versions that old.

you can check with:

$ autoconf --version
$ head ptest/testsuite

[Charles Daniels]

Can confirm that updating to a newer autoconf version resolved this issue.