vansante / go-ffprobe

Library to easily get the ffprobe output of a given file

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Release new version

paolobarbolini opened this issue · comments

Could you release a new version?

In particular I see this change b3d5705 where you use better names for constants to make them play nice with golint and in a comment you plan deprecate the old constants names:

go-ffprobe/probedata.go

Lines 10 to 31 in b3d5705

const (
// StreamAny means any type of stream
StreamAny StreamType = ""
// StreamVideo is a video stream
StreamVideo StreamType = "video"
// StreamAudio is an audio stream
StreamAudio StreamType = "audio"
// StreamSubtitle is a subtitle stream
StreamSubtitle StreamType = "subtitle"
)
// TODO: FIXME: We should remove the ALL_CAPS variants some time in the future (golint hates them)
const (
// STREAM_ANY deprecated, use StreamAny
STREAM_ANY = StreamAny
// STREAM_VIDEO deprecated, use StreamVideo
STREAM_VIDEO = StreamVideo
// STREAM_AUDIO deprecated, use StreamAudio
STREAM_AUDIO = StreamAudio
// STREAM_SUBTITLE deprecated, use StreamSubtitle
STREAM_SUBTITLE = StreamSubtitle
)

But since Go modules (which will be enabled by default in Go 1.13) by default install the latest git tag, that change isn't going to be available to most users who are simply going to install this using go get github.com/vansante/go-ffprobe without giving it much thought, since the commit that made that change came after the latest release, which currently is v1.0.0

Great. Thank you.