Request for further documentation

Question

Request for further documentation

aiavci opened this issue 6 years ago · comments

Version
v0.2.0

Details
The documentation on this library has much room for improvement. I'm getting an error when using this library but I'm not even if I'm using it the way it was intended.

Bug Details
When I call:
onView(withChild(withTextViewDrawableLeft(R.drawable.example))) .check(matches(isDisplayed()))

I get:
java.lang.NullPointerException: Attempt to invoke virtual method 'android.graphics.drawable.Drawable$ConstantState android.graphics.drawable.Drawable.getConstantState()' on a null object reference at com.vanniktech.espresso.core.utils.Utils.drawableMatches(Utils.java:46)

Niklas Baudy · Answer 1 · Tue Mar 13 2018 03:56:44 GMT+0800 (China Standard Time)

The image you're checking against has no drawable set. Are you missing javadoc?

Ali Avci · Answer 2 · Tue Mar 13 2018 21:28:11 GMT+0800 (China Standard Time)

To my understanding the correct approach is to validate against specific views instead of the method actually finding the drawable for you. This wasn't clear through the documentation.
i.e. Instead of calling:

onView(withId(R.id.example_view))
                .check(matches(withTextViewDrawableLeft(R.drawable.example))))

I should have called:
onView(withId(R.id.example_view)).check(matches(withTextViewDrawableLeft(R.drawable.example)))

Niklas Baudy · Answer 3 · Tue Mar 13 2018 21:32:11 GMT+0800 (China Standard Time)

Oh okay got it. I'll do some more javadoc and also adjust the README.

Niklas Baudy · Answer 4 · Wed Mar 14 2018 03:44:13 GMT+0800 (China Standard Time)

I hope you like the improvements. Thanks for the suggestion.