Giters

vanna-ai / vanna

🤖 Chat with your SQL database 📊. Accurate Text-to-SQL Generation via LLMs using RAG 🔄.

Home Page:https://vanna.ai/docs/

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Why is settings for `n_results` not supported for `get_related_documentation` and `get_related_ddl`?

imzdu opened this issue · comments

commented

Hi Team,

Would like to understand why the argument n_results is supported for get_similar_question_sql:
https://github.com/vanna-ai/vanna/blob/fe2d4396c2ca946790895b441dbefa65c5af890f/src/vanna/chromadb/chromadb_vector.py#L233C9-L233C33

But not for get_related_documentation or get_related_ddl? See reference below:

https://github.com/vanna-ai/vanna/blob/fe2d4396c2ca946790895b441dbefa65c5af890f/src/vanna/chromadb/chromadb_vector.py#L243C13-L243C39

Would like the ability to set how many documents or ddl statements to consider for in-context learning.

commented

@imzdu Just so that you are aware. There has been implemented a PR to address this: #354

Hopefully it will be merged and a new release will be made very soon. Any update on when the release will be made, @zainhoda? :]

commented

Oh @andreped I thought you were going to test that change on your end. If you’re good with it, I’ll release that as a minor patch

commented

Oh @andreped I thought you were going to test that change on your end. If you’re good with it, I’ll release that as a minor patch

Oh, I meant after the release was made. Probably no need for me to test if local tests pass?

But I could do the test tomorrow, if you'd like. Just left work.