`@vanilla-extract/css` only work with pnpm!
raphaelboukara opened this issue · comments
Describe the bug
This commit migrate from ahocorasick to modern-ahocorasick without majoring @vanilla-extract/css.
However, this change is a breaking change since from those changes, pnpm is required to install modern-ahocorasick, means now vanilla-extract became available only for people that use pnpm.
Warning
By chance, because of this npm issue: npm/cli#2660, the script that check pnpm presence won't work, but if you are using for instance node 14 and npm: install will fail.
When this issue will be fixed, all people that installed vanilla-extract with npm will be affected.
Note
To reproduce:
$ git clone git@github.com:raphaelboukara/ahocorasick.git
$ cd ahocorasick
$ nvm use
$ npm i
Reproduction
https://github.com/raphaelboukara/ahocorasick
System Info
System:
OS: macOS 13.4.1
CPU: (10) x64 Apple M2 Pro
Memory: 419.46 MB / 32.00 GB
Shell: 5.9 - /bin/zsh
Binaries:
Node: 14.21.3 - ~/.nvm/versions/node/v14.21.3/bin/node
npm: 6.14.18 - ~/.nvm/versions/node/v14.21.3/bin/npm
Browsers:
Chrome: 119.0.6045.123
Safari: 16.5.2Used Package Manager
npm
Logs
╔═════════════════════════════════════════════════════════════╗
║ ║
║ Use "pnpm install" for installation in this project. ║
║ ║
║ If you don't have pnpm, install it via "npm i -g pnpm". ║
║ For more details, go to https://pnpm.js.org/ ║
║ ║
╚═════════════════════════════════════════════════════════════╝Validations
- Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.
- The provided reproduction is a minimal reproducible example of the bug.
I think the upstream package probably shouldn't use only-allow in a preinstall script as it was probably meant to only be used in apps rather than packages. I have made a PR upstream sonofmagic/modern-ahocorasick#11. If that isn't merged soon, we'll revert the change.
modern-ahocorasick@1.0.1 has been released to resolve this problem, thanks @askoufis
Issue resolved. thanks @askoufis