Giters

valkey-io / valkey

A new project to resume development on the formerly open-source Redis project. We're calling it Valkey, since it's a twist on the key-value datastore.

Home Page:https://valkey.io

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Valkey change proposal (VCP) repository

madolson opened this issue · comments

commented

Redis used to have the RCP (Redis change proposal) project. Right before the license change, we agreed to revive that project and start putting larger initiatives there. For example, https://github.com/valkey-io/valkey/pull/75/files as well as clusterv2 can have their design documents living there.

@valkey-io/contributors does anyone have any concerns with that. And/or, does anyone want to volunteer to create the repository and create some guidelines for using it?

commented

Sgtm. My only concern is that we'll end up merging something slightly different in the end and that these proposals will become an outdated description of the feature.

At the same time, it looks very close to documentation. Can a proposal like this live as an open PR to the docs repo?

commented

At the same time, it looks very close to documentation. Can a proposal like this live as an open PR to the docs repo?

The main difference, imo, is that a VCP will be much more technically detailed than most documentation. They will go through the design options, which inform why the decision was made.

commented

Is this the correct work flow to work with VCP repo?

  1. One feature proposed here (valkey-io/valkey) ---- Create an issue
  2. Discussion here and approval
  3. Update technical detail in Valkey change proposal (VCP) repository
  4. Create a PR
  5. Merge to unstable branch

Let us confirm it, Thanks

commented

@hwware I agree with that. Don't start with the VCP, start with the high level proposal first.