Debian packaging tweaks
williamdes opened this issue · comments
Hi,
I do Debian packaging for the official Debian repository.
I noticed:
- The README instructions are outdated (the GPG add key part)
Here is the good new way: https://blog.williamdes.eu/Infrastructure/tutorials/install-dell-idrac-racadm-on-proxmox-7/
https://github.com/valeriansaliou/vigil/blob/master/README.md#installation - I am not sure why you need
Provides(https://www.debian.org/doc/debian-policy/ch-relationships.html#virtual-packages-provides)
Line 12 in a777e86
- The standards version are 4.6.2 today (https://www.debian.org/doc/debian-policy/upgrading-checklist.html#version-4-6-2)
Line 5 in a777e86
- Priority is invalid (https://www.debian.org/doc/debian-policy/ch-controlfields.html#priority)
I think you did mean extra, it is deprecated andoptionalis the replacement.
Line 3 in a777e86
Also, the packaging method is insecure, you could check that the downloaded tarball is gpg verified ;)
This is not criticism, I really want to help you with the Debian packaging.
Why not having vigil in Debian itself ?
Hello!
Thank you for this issue, issue number 1 has been fixed in 3267dcc
On the other issues, I'll let them be as-is for now as this setup works for me, however if you'd like to help improve & submit Vigil to Debian official packages, I'll be super glad! :)
Hello!
Thank you for this issue, issue number 1 has been fixed in 3267dcc
Thank you!
On the other issues, I'll let them be as-is for now as this setup works for me, however if you'd like to help improve & submit Vigil to Debian official packages, I'll be super glad! :)
Can you at least fix the Priority it's totally a bug
I can start the process and see how I could manage to package vigil.
You should definitely change Provides to something like web-status-page
Just like browsers Provide: www-browser
That allows any package to say, I depend on a www-browser
Having vigil in Debian would be awesome!
But all dependencies recursivly will need to be packaged one separately by one before vigil. That's how it goes mostly 😄
Here is the dependency list:
- log (https://tracker.debian.org/pkg/rust-log)
- clap (https://tracker.debian.org/pkg/rust-clap)
- lazy_static (https://packages.debian.org/sid/librust-lazy-static-dev)
- time (https://tracker.debian.org/pkg/rust-time)
- serde (https://tracker.debian.org/pkg/rust-serde)
- serde_derive (https://packages.debian.org/sid/librust-serde+serde-derive-dev)
- toml (https://tracker.debian.org/pkg/rust-toml)
- envsubst (seems missing)
- uuid (https://tracker.debian.org/pkg/rust-uuid)
- regex (https://tracker.debian.org/pkg/rust-regex)
- url (https://tracker.debian.org/pkg/rust-url)
- url_serde (https://packages.debian.org/sid/librust-url+serde-dev)
- http (https://tracker.debian.org/pkg/rust-http)
- http-serde (seems missing)
- indexmap (seems missing)
- actix-web (seems missing)
- actix-files (seems missing)
- actix-web-httpauth (seems missing)
- tera (https://tracker.debian.org/pkg/rust-tera)
- native-tls (https://tracker.debian.org/pkg/rust-native-tls)
- openssl-probe (https://tracker.debian.org/pkg/rust-openssl-probe)
- reqwest (https://tracker.debian.org/pkg/rust-reqwest)
- ping (seems missing)
- run_script (seems missing)
- lettre (seems missing) used by the feature notifier-email
- libstrophe (exists but not as a Rust lib) could be skipped if the feature notifier-xmpp is removed
The list is mostly complete, I can try to do the packaging the official way. Adding some hacks to have the missing libs (will it work?)
Eventually when the list is complete, we can convert your packaging method to the official one.
No crates.io, no Internet. Everything must build from source and Debian archive.
Vigil being built with MUSL it doesn’t depend on anything and is totally autonomous. Why would it need to depend on all those Debian packages?
Vigil being built with MUSL it doesn’t depend on anything and is totally autonomous. Why would it need to depend on all those Debian packages?
Good question, the dependencies are needed to build vigil. Let's say you have a bunker and the source code of vigil and a Debian archive.
If you take all this you can build vigil
There is only some dependencies missing in Debian
Anyway, official Debian packages can not be built from Internet sources.
Do you understand such build systems, maybe I can try to give more examples
I totally understand the rationale. However, I think this will be too much work for me to maintain on the side as an extra, I'm all good w/ the current Debian packaging system that pushes a minimal .deb on Packagecloud. I'll be honestly, I'm doing this to save time updating all my servers on Crisp, doing it in a "more proper way" would cost more time than it saves me.
I totally understand the rationale. However, I think this will be too much work for me to maintain on the side as an extra, I'm all good w/ the current Debian packaging system that pushes a minimal
.debon Packagecloud. I'll be honestly, I'm doing this to save time updating all my servers on Crisp, doing it in a "more proper way" would cost more time than it saves me.
Sure, but if you want vigil to be into Debian it's important that you understand how things are done to ensure a ton of different aspects and reasons
So yeah it's not a big deal for you to build the binary and put it into a package on package cloud.
I am really willing to package vigil on Debian if you are interested to have in on official Debian.
It's more like a collaboration, I could do it without collaboration but it will end up costing me more free time in the end if I have to patch your software for example
Let me know how all this feels
It will also end up in Ubuntu
All right then, go for it! Happy to see it in Debian + Ubuntu :)
All right then, go for it! Happy to see it in Debian + Ubuntu :)
Let's go!
I will keep you updated on the process, it can take a very long time ^^
But having it in the next Debian gives a two year time frame, definitely possible to have it done
Do you want it in Linux alpine too?
The packaging is way easier, I already packaged a Rust tool: Horust
Thank you so much! I think Debian + Ubuntu will already be far enough :)