vaimo / composer-patches

Applies a patch from a local or remote file to any package that is part of a given composer project. Patches can be defined both on project and on package level. Optional support for patch versioning, sequencing, custom patch applier configuration and composer command for testing/troubleshooting patches.

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Cannot be used with PHP version over 5.6

ronald2wing opened this issue · comments

drupol/phposinfo 1.6.1.2 requires php ^5.3 || ^5.4 || ^5.5 || ^5.6 -> your PHP version (7) does not satisfy that requirement.

The dependency does not allow php version over 5.6.

@drupol, why exactly is there such a constrain in place? :/ As far as I see, there's no real reason to have such a limitation code-wise.

It's definitely my own short-sightedness as well as I should have noticed such an issue beforehand.

Please use 4.17.10 & 3.48.10 releases until this issue has been cleared + thank you very much for pointing this out!

Hi,

drupol/phposinfo 1.6.1.2 requires php ^5.3 || ^5.4 || ^5.5 || ^5.6
drupol/phposinfo 1.6.1 requires php >= 7.1.3

Here's how I work with my branches, it may not be the best workflow, but I wasn't able to find such an easier way to maintain a project for different versions of PHP.

  • Develop in master branch (for PHP >= 7.1.3)
  • Tag a new release in master, ex: 1.7.0
  • Create a new branch 1.7.0.0 from master
  • Merge the previous branch 1.6.0.0 on it to ensure PHP compatibility with lower versions of PHP.
  • Tag a new release 1.7.0.1

I wasn't able to find a better branching model for maintaining a package working with different versions of PHP.

Let me know if I can improve this so it works for you.

Thanks.

I guess just updating the composer.json from

    `"drupol/phposinfo": "^1.6.1.2",`

to

    `"drupol/phposinfo": "^1.6.1",`

Will be sufficient to get it working for all the PHP versions.

Yup one of the things there is indeed the fact that the constraint is defined in such a strict manner. Will change that.

The version that is not covered after making this change though: 7.0

I'd take that the version that works on 5.X would work just fine on 7.0 as well (if the constraints on said package could be expanded a bit.

Hi,

I just tagged 1.6.1.3 to support PHP 7.0.

Solved in 4.19.2 & 3.50.2

Thanks :)

Thank you as well :)

Took some extra time to make sure that this will not be missed in the future.