vacarsu / uikit-react

UIkit components wrapped with React

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

[FEATURES] Support both ESM and CommonJS, inherit parent props implicitly, and reduce package size

aaronhuggins opened this issue · comments

I'm currently working on implementing the following over on my fork (https://github.com/aaronhuggins/uikit-react):

  • Support CommonJS (required for server-side rendering applications)
  • Inherit parent props implicitly (Reduces the amount of manual coding require to fully support input elements, for example)
  • Reduce package size (only package minimum set of folders and files for complete functionality)
  • May also implement Fragments to cover cases where extra parent divs are added to the dom for some components (good example for this use-case is NavbarContainer).

I'd like to open one or more pull requests as I complete this work to contribute it back, @vacarsu. Are these something you'd like to have completed? Would you like an individual PR for each item?

@vacarsu Also, phenomenal work on this lib. I absolutely adore uikit, and I'm happy to see it getting some JSX lovin'.

Hi, @aaronhuggins these changes look very good to me. I think separate PRs would be best to review and track the changes.