uxmal / reko

Reko is a binary decompiler.

Home Page:https://uxmal.github.io/reko

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Feature request: Indicate position of Memory View window on address space bar

throwaway96 opened this issue · comments

You could apply a translucent overlay or invert the colors of the area corresponding to what's visible in the Memory View. It also may be desirable to add an indication of the current selection.

I've completed implementing showing the selected address range in the address bar. Can you attach a screen shot, using mspaint or the like to indicate what you wish to happen when you ask:

apply a translucent overlay or invert the colors of the area corresponding to what's visible in the Memory View

Here is a manipulated screenshot; note the new "selected address" in the status bar. Do you want the pink area to be updated as the selection changes (color would of course be different)? Or do you want other user interface elements to change color?
slask

What I meant was something like this:
address-highlight
The highlighted part of the bar would correspond with what's visible on the screen (003AFFB0-003B0110 in this example). I'm not sure whether the selection should show up on the address bar. It'll probably be relatively small in most cases, although I guess it could just appear as a line. Maybe what's visible on the screen should be highlighted (or outlined) in one color, and the selection would be another (darker?) color.

I do also want what you've shown in your image. This is how HxD does it:
image
image
The darker color is what's actually selected.

Commit 97f596b now tracks the selection in the imagemap view:image

Last remaining part is selecting the char-bytes part of the selection.

Text side of the memory control is now fully selectable, just like the numeric side. The "other side" will be highlighted so it's easier to see the selection:
image
The features requested have been implemented. If you can think of improvements, please feel free to open a new issue and describe them.