Inconsistent inlining?

Question

Inconsistent inlining?

kinggoesgaming opened this issue 3 years ago · comments

https://github.com/uuid-rs/uuid/blob/main/src/fmt.rs#L19-L62

I have seen inconsistent inlining for the various Uuid fmt traits. I am not sure that is by design, since I did not review the changes when they were made. Just wanted to bring it up, since we are that close to 1.0 release.

Hunar Roop Kahlon · Answer 1 · Tue Nov 02 2021 06:32:24 GMT+0800 (China Standard Time)

Actually also exists for the adapters as well, inside the macro rules, further down the file

Ashley Mannix · Answer 2 · Tue Nov 02 2021 06:36:34 GMT+0800 (China Standard Time)

Ah, this is quite possibly not by design 😄

We can add these inlines at any time, but it would be great to have a look and see which ones are worthwhile.

Hunar Roop Kahlon · Answer 3 · Sun Nov 07 2021 07:59:28 GMT+0800 (China Standard Time)

Considering that the release is still looking a bit away (looking at you, #557), I'll benchmark inlines and no inlines tomorrow and get a PR open according

Edit: fix grammar

Ashley Mannix · Answer 4 · Mon Mar 14 2022 10:03:24 GMT+0800 (China Standard Time)

I think our inlines are probably pretty accurate now after all the optimization work done in the last few months. I'll go ahead and close this one, and any specific issues that come up can create fresh ones.