Review

[Utkarsh Sengar]

Hi @timothy1ee, please review the rotten tomatoes app.

[Timothy Lee]

Good job! The point of this homework was to explore a simple example of a full MVC application with a RESTful API. When I'm auditing the code, I use the checklist below. If you didn't do one of the items below, you should consider implementing it.

• Movie model. Did you have some way to create it from a dictionary?
• You should have implemented a custom cell. When creating a custom cell, make sure never to use imageView, titleLabel, or subtitleLabel. Those are already used by UITableViewCell and using them in your custom cell will cause subtle things to happen such as image views not loading until you click on the cell.
• If you chose to embed an image, you should have loaded the images asynchronously. One way to do that was to use AFNetworking, installed via CocoaPods.
• If you had an image, you should observe the UIContentMode of the UIImageView. By default, it will stretch the image to match your dimensions, which is probably not what you want.
• If you had a custom cell, you should configure the Auto Layout parameters. We'll review that in class.
• Did you display some loading indicator while you were fetching the movies.
• Did you display an error if you failed while fetching the movies.

[Utkarsh Sengar]

• Movie model. Did you have some way to create it from a dictionary?
  Sure, I thought it didn't add much value. But I will add it tonight.
• You should have implemented a custom cell. When creating a custom cell, make sure never to use imageView, titleLabel, or subtitleLabel. Those are already used by UITableViewCell and using them in your custom cell will cause subtle things to happen such as image views not loading until you click on the cell.
  I have implemented a custom cell; https://github.com/utkarsh2012/cp-week1-p1/blob/master/tomatoes/MovieCell.h Am I missing something here?
• If you chose to embed an image, you should have loaded the images asynchronously. One way to do that was to use AFNetworking, installed via CocoaPods.
  I have used AFNetworking to load images asynchronously in both the views.
• If you had an image, you should observe the UIContentMode of the UIImageView. By default, it will stretch the image to match your dimensions, which is probably not what you want.
  Was not aware about this, will work on it too.
• If you had a custom cell, you should configure the Auto Layout parameters. We'll review that in class.
• Did you display some loading indicator while you were fetching the movies.
  Yes. I am using SVProgressHUD
• Did you display an error if you failed while fetching the movies.
  Yes, I check if there is no connectivity I render an error using SVProgressHUD.

[Timothy Lee]

This is just a checklist that I use to help you understand when you did things right. You'll see the value of models as we move to more complex apps.

You should try displaying the error as it is in the sample mock, not using the progress hud.

[Utkarsh Sengar]

Alright, thanks!
I will try to display errors in a different way.