Project Feedback!
codepathreview opened this issue · comments
Hello Utkarsh,
👍 nice work. The point of this homework was to explore a simple example of a full MVC application with a RESTful API.
Here's a checklist of things that I'm looking for in this project. You should review the checklist, and make any changes to your project, if necessary.
- Code styling.
- In Objective-C, The New York Times has a good summary of appropriate Objective-C coding conventions, you should take a quick look here.
- In Swift, check out the Ray Wenderlich Swift Style Guide and the Github Swift Style Guide
- In Objective-C, review your .h files. In Swift, review the properties and methods that you've made public. Your classes should reveal a minimum interface and only expose things that must be used by other classes.
- If you're using Objective-C, you can consider using Mantle, a lightweight ORM that eliminates a lot of boilerplate. It's also compatible with Core Data if your project requires that.
- If you're using Swift, you can consider using SwiftyJSON for easier deserialization of the JSON response.
- When creating a custom cell, make sure never to use imageView, titleLabel, or subtitleLabel. Those are already used by UITableViewCell and using them in your custom cell will cause subtle things to happen such as image views not loading until you click on the cell.
- The images should be downloaded asynchronously. One way to do that was to use AFNetworking, installed via CocoaPods.
- Observe the UIContentMode of the UIImageView. By default, it will stretch the image to match your dimensions, which is probably not what you want.
- Next week, we'll cover how to use Auto Layout constraints to implement dynamic height rows and adjust to synopsis of different length.
In general, you should challenge yourself to create visually polished applications. That's where you'll find all the rough edges of the iOS framework and earn the next level of mastery.