DLS: Image requirements need to be added to all components that have an image
lalov1 opened this issue · comments
@ bennie-aranda - Could you handle this one? I didn't start working on this, but it might be good for you.
Could you add the Media Requirements to the notes of all components with images? Here is an example of one already completed:
https://utsa-asc.github.io/college-dls/components/detail/profile-card--default.html
You can find a lot of the placeholders here:
https://walledev.it.utsa.edu/entity/open.act?id=420d837d81736a1b55fcab75ae19a99d&type=folder
Please feel free to reach out to me or @Uri-E with any questions.
So the changes would need to be made via vs code? I am currently on 01-profile-card and I see two hbs files for profile-card. I am assuming I would put the media requirements in there ?
Yes, they would need to be made via VS Code. They would be in the markdown file, which has the .md extension. The profile-card.readme.md already has the media requirements, but you would be adding that to the other sections that need image requirements.
oh okay got it I was looking at the wrong files. Thank you for pointing me in the right direction!
I noticed a typo on the "Image should be no larger and 300kb (kilobytes)"
did you want me to change it to "no longer than"?
**larger
I think it's fine since it's referring to the above since it's a sub-bullet:
The 300kb is a little large, so you should ask @ Uri-E if it should be less than that.
oh okay got it I just thought maybe it was a typo
Reopening issue because all components need image requirements. You can find the placeholder images here with the dimensions:
https://walledev.it.utsa.edu/entity/open.act?id=420d837d81736a1b55fcab75ae19a99d&type=folder
In the future, do not merge branches into main, but request a review from the team upon completion.