Giters

usdigitalresponse / usdr-gost

USDR-hosted grants management tools

Home Page:http://grants.usdigitalresponse.org

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

[Issue]: Remove Upcoming Closing Date from Dashboard

ClaireValdivia opened this issue · comments

commented

Why is this issue important?

Upcoming closing dates "see more activity" link has had no activity in the past 6 months and we have not heard from users that this is valuable to them. We are removing to highlight more useful content on the page.

Current State

Upcoming closing dates show grants marked as "interested" for the user's team that also fall within the danger or warning thresholds set for the team.

Expected State

Remove "Upcoming Closing Dates" section from Dashboard
Increase max width of "Recent Activity" section by 150%

Implementation Plan

Client-side changes

  • In packages/client/src/views/DashboardView.vue:
    • Remove the <b-col> container for the "Upcoming Closing Date" section and all of its contents. This will remove that section and allow expansion of the remaining "Recent Activity" section.
    • Remove the first empty <b col cols="1"> element to shift the "Recent Activity" section's alignment to the left.
    • Clean up the styles and exported script behavior in the view that are no longer used following removal of the "Upcoming Closing Date" section.
  • Delete the packages/client/src/components/ClosingDatesTable.vue component file and refactor the packages/client code to remove any/all remaining usages.
  • Delete the packages/client/src/views/UpcomingClosingDatesView.vue view file and refactor the packages/client code to remove any/all remaining usages, including its Vue route and any API calls.
  • Check for and prune any/all other "dead code" that results from removing the "Upcoming Closing Dates" component and view.

API-side changes

  • In packages/server/src/routes/grants.js, remove the /closestGrants/:perPage/:currentPage API route handler.
  • In packages/server/src/db/index.js, remove the getClosestGrants() function, which should no remaining callers following removal of the /closestGrants/:perPage/:currentPage route.
  • Check for and prune any/all other "dead code" that results from removing the /closestGrants/:perPage/:currentPage route (including unit tests, which may now be failing).
commented

@ClaireValdivia Implementation details added.

commented

This looks great, thanks Maya!!