Backport NDEBUG fix to 0.9.3

Question

Backport NDEBUG fix to 0.9.3

jdemilledt opened this issue 5 years ago · comments

The NDEBUG issue is breaking for me, as I'm trying to update uriparser on Homebrew, but I do not want to disable tests. Could this be backported to a new tag so I can still work off of releases? If not, when would 0.9.4 be coming?

Sebastian Pipping · Answer 1 · Fri May 10 2019 04:50:45 GMT+0800 (China Standard Time)

Hi! Are the test being run during installation with homebrew?

Julian DeMille · Answer 2 · Fri May 10 2019 21:19:25 GMT+0800 (China Standard Time)

The tests are run at build time, as required by the Homebrew team.

…

On Thu, May 9, 2019 at 4:50 PM Sebastian Pipping ***@***.***> wrote: Hi! Are the test being run during installation? — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#70 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AG6L6WNLLRSGEYCCHHA4T23PUSFCNANCNFSM4HLTTBUA> .

-- Julian DeMille CEO, demilleTech, LLC. This email and any files transmitted with it are confidential and intended solely for the use of the individual or entity to whom they are addressed. If you have received this email in error please notify the system manager. This message contains confidential information and is intended only for the individual named. If you are not the named addressee you should not disseminate, distribute or copy this e-mail. Please notify the sender immediately by e-mail if you have received this e-mail by mistake and delete this e-mail from your system. If you are not the intended recipient you are notified that disclosing, copying, distributing or taking any action in reliance on the contents of this information is strictly prohibited.

Sebastian Pipping · Answer 3 · Mon May 13 2019 03:40:09 GMT+0800 (China Standard Time)

That's cool actually. As well as the wish to keep downstream with zero patches.

I'm still struggling a bit with how to move forward. Would https://github.com/uriparser/uriparser/archive/f870e6c68696a6018702caa5c8a2feba9b0f99fa.tar.gz with the patch be a pain to integrate with homebrew (and be any better to you than 0.9.3 tarball plus a patch files to apply)?

Other options all seem o suck some way:

a) roll a full 0.9.4 with all it takes — see #66
b) roll 0.9.4 but skip most steps
c) just tag 0.9.3.1, no real release, only tarballs generated by GitHub (no make dist upload)

What do you think?

Julian DeMille · Answer 4 · Mon May 13 2019 03:55:01 GMT+0800 (China Standard Time)

There are two options for the install, release and HEAD, so the direct commit is out of the question. The most SemVer compliant ways are a and b, but it does seem a bit excessive for a single bug fix. `0.9.3-2` seems the most elegant, marking it as a patch of 0.9.3, but it isn't very SemVer-friendly.

…

On Sun, May 12, 2019 at 3:40 PM Sebastian Pipping ***@***.***> wrote: That's cool actually. As well as the wish to keep downstream with zero patches. I'm still struggling a bit with how to move forward. Would https://github.com/uriparser/uriparser/archive/f870e6c68696a6018702caa5c8a2feba9b0f99fa.tar.gz with the patch be a pain to integrate with homebrew (and be any better to you than 0.9.3 tarball plus a patch files to apply)? Other options all seem o suck some way: - a) roll a full 0.9.4 with all it takes — see #66 <#66> - b) roll 0.9.4 but skip most steps - c) just tag 0.9.3.1, no real release, only tarballs generated by GitHub (no make dist upload) What do you think? — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#70 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AG6L6WONJWAPZAZNLF3EIJ3PVBXBTANCNFSM4HLTTBUA> .

-- Julian DeMille CEO, demilleTech, LLC. This email and any files transmitted with it are confidential and intended solely for the use of the individual or entity to whom they are addressed. If you have received this email in error please notify the system manager. This message contains confidential information and is intended only for the individual named. If you are not the named addressee you should not disseminate, distribute or copy this e-mail. Please notify the sender immediately by e-mail if you have received this e-mail by mistake and delete this e-mail from your system. If you are not the intended recipient you are notified that disclosing, copying, distributing or taking any action in reliance on the contents of this information is strictly prohibited.

Sebastian Pipping · Answer 5 · Mon May 13 2019 04:09:47 GMT+0800 (China Standard Time)

The more I think about it and remember that I went with the patch file approach for Gentoo — see gentoo/gentoo@3d5e8ca — I wonder if you would be very disappointed if I kept the next release waiting for a real bugfix: A fix on your side is 10 minutes I would guess (based on my Gentoo take earlier), a new release on my side is a lot more and all approaches seem suboptimal as well. Also homebrew and Gentoo might be the only two running the test suite during installation. Okay?

Julian DeMille · Answer 6 · Mon May 13 2019 05:51:49 GMT+0800 (China Standard Time)

Sounds good for now, seems like a lot of work for just a simple test fix, so I'll use the patch for now.

Sebastian Pipping · Answer 7 · Tue May 14 2019 03:30:21 GMT+0800 (China Standard Time)

Thanks for your understanding!