Please tag for 0.9.2

Question

Please tag for 0.9.2

jgsuess opened this issue 5 years ago · comments

Jörn Guy Süß commented 5 years ago

Hi, I would like to use 0.9.2, because of the cmake build availability. Could you tag the repo so I can pull this in?

Sebastian Pipping · Answer 1 · Thu Mar 21 2019 06:56:02 GMT+0800 (China Standard Time)

I agree that a new release is in order. I'll need a few days more

David · Answer 2 · Fri Apr 12 2019 06:01:38 GMT+0800 (China Standard Time)

Does this release generate the missing cmake files when installing? I have an open case in Vcpkg (microsoft/vcpkg#5987).

Thanks

Sebastian Pipping · Answer 3 · Sun Apr 14 2019 02:08:11 GMT+0800 (China Standard Time)

Hi @david-antiteum the upcoming release is the first including a CMakeLists.txt file. There is no better time than checking if it does what you need then now 😃

Sebastian Pipping · Answer 4 · Wed Apr 17 2019 05:37:47 GMT+0800 (China Standard Time)

@david-antiteum #60 that affects compilation on Windows was just merged and might be of interest to you. Do you have plans for a test spin in the next few days? I wonder if I should wait with the release more or not. Thanks!

David · Answer 5 · Wed Apr 17 2019 13:57:20 GMT+0800 (China Standard Time)

I can do the test next week using master. David El El mar, 16 abr 2019 a las 23:37, Sebastian Pipping < notifications@github.com> escribió:

…

@david-antiteum <https://github.com/david-antiteum> #60 <#60> that affects compilation on Windows was just merged and might be of interest to you. Do you have plans for a test spin in the next few days? I wonder if I should wait with the release more or not. Thanks! — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#57 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AukvJTZ5g8vebJg5TlNfeqiJdspWrbJqks5vhkKrgaJpZM4b4to9> .

Sebastian Pipping · Answer 6 · Wed Apr 17 2019 19:47:37 GMT+0800 (China Standard Time)

@david-antiteum Cool, thanks in advance!

David · Answer 7 · Mon Apr 22 2019 18:22:13 GMT+0800 (China Standard Time)

Looks good to me. I have compiled the version in Windows with no issues both directly and using vcpkg's install command. cmake files are configured correctly and I can just use it with:

find_package(uriparser CONFIG REQUIRED)
target_link_libraries(main PRIVATE uriparser::uriparser)

As soon as you tag the version as 0.9.2 I will update the port file for vcpkg.

Thanks.

Sebastian Pipping · Answer 8 · Tue Apr 23 2019 04:14:56 GMT+0800 (China Standard Time)

@david-antiteum thanks for testing!

The release with all its different parts is tracked at #61.

Release archives are uploaded by now, for vcpkg this might be the URL you want:
https://github.com/uriparser/uriparser/releases/download/uriparser-0.9.2/uriparser-0.9.2.zip

David · Answer 9 · Tue Apr 23 2019 05:40:21 GMT+0800 (China Standard Time)

Thanks ... I have opened a PR in vcpkg with the new version.

Sebastian Pipping · Answer 10 · Tue Apr 23 2019 14:35:05 GMT+0800 (China Standard Time)

Cool, thank you!

microsoft/vcpkg#6178