Vendor usage of `github.com/xrash/smetrics` for suggestions
meatballhat opened this issue · comments
Dan Buch commented
The usage of smetrics.JaroWinkler
should be vendored into this source tree or replaced with an implementation that is within this source tree to support the goal of only requiring the Go standard library.
Yiğithan Karabulut commented
smetrics.JaroWinkler on line 25 in suggestions.go file, do we need to write this function instead of using it? If so, could you assign to me?
Dan Buch commented
@yigithankarabulut Thank you! Replacing the function usage with an internal function SGTM. Vendoring the library implementation with attribution is also acceptable. Your call!