urfave / cli

A simple, fast, and fun package for building command line apps in Go

Home Page:https://cli.urfave.org

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Add testify, and update tests to use it rather than expect

skelouse opened this issue · comments

Checklist

  • Are you running the latest v3 release? The list of releases is here.
  • Did you check the manual for your release? The v3 manual is here.
  • Did you perform a search about this feature? Here's the GitHub guide about searching.

What problem does this solve?

Simplifies tests, i.e

if err != nil {
	t.Error(err)
	return
}

Becomes

assert.NilError(t, err)

Solution description

import stretchr/testify in tests and replace value checking in tests with testify

@dearchap was there a reason for the close? I opened this based on a comment on the mentioned PR.

Ah ok. Sorry I thought that PR was the fix for this.