After upgrade to upscayl 2.11.0 some models hangs on processing
osts opened this issue · comments
Checklist
- I have tried ALL of the steps mentioned in the troubleshooting guide.
- I have searched for this in the issues tab.
- My error involves vkEnumeratePhysicalDevices or vkCreateInstance, which means I should ignore the other issues and file this one despite the last checkbox.
Describe the Bug
After upgrade to upscayl 2.11.0 some models hangs on processing. It seems that processing problems is with models which don't have scale like 4x or x4 in name. For example - not working bundled model GENERAL PHOTO (ULTRASHARP) . I added to case error from log. Suggestion - maybe in code is way to assigng 4x scale when scale is not mentioned in model name?
To Reproduce
Process image with GENERAL PHOTO (ULTRASHARP) model
Upscayl Version (or commit hash)
2.11.0
Platform
Linux
OS Version
Ubuntu 22.04.3
GPU Name
NVIDIA
Expected Behavior
No response
Screenshots
Logs
12:00:47.511 › 🚧 UPSCAYL_PROGRESS: 🚀 Starting Upscayl - Copyright © 2024
🚨 Error: The model name doesn't contain scale. Please make sure that the model name contains x2, x3, x4, etc. or 2x, x3, x4, etc.
Uh oh, I'll push a hotfix ASAP!
The issue was here in upscayl-ncnn. It was just returning if the model name didn't have the scale value, it was even ignoring the -z switch 😅
I'll be updating the binaries of v2.11
I've updated the binary and the issue has been fixed. Please re-download the exe from the latest release section. Thank you for reporting the bug and sorry for the trouble