2.10.9 Upscale Failure

Question

2.10.9 Upscale Failure

WeirdScienceX opened this issue 2 months ago · comments

WeirdScienceX commented 2 months ago

Checklist

I have tried ALL of the steps mentioned in the troubleshooting guide.
I have searched for this in the issues tab.
My error involves vkEnumeratePhysicalDevices or vkCreateInstance, which means I should ignore the other issues and file this one despite the last checkbox.

Describe the Bug

Fails to upscale, appears to be looking in the wrong location for models

To Reproduce

Try to upscale any image

Upscayl Version (or commit hash)

2.10.9

Platform

Windows

OS Version

Win 11 23H2

GPU Name

RTX 3080TI

Expected Behavior

Image Upscaled

Screenshots

No response

Logs

⚙️ Getting saveImageAs from localStorage:  png
⚙️ Getting model from localStorage:  {"label":"General Photo (Ultramix Balanced)","value":"ultramix_balanced"}
⚙️ Setting gpuId to empty string
🔀 Setting model to 
𝌖 BACKEND REPORTED:  📁 Updating Output Folder Path:  "D:\\TEMP\\misc"
🔀 Setting model to ultramix_balanced
𝌖 BACKEND REPORTED:  💾 Updating Remember Output Folder:  false
🔄 Resetting image paths
⤵️ Dropped file:  {"type":"image/png","filePath":"D:\\TEMP\\misc\\boat1.png","extension":"png"}
🖼 Setting image path:  D:\TEMP\misc\boat1.png
🗂 Setting output path:  D:\TEMP\misc
🖼 imagePath:  D:\TEMP\misc\boat1.png
🔤 Extension:  png
🔄 Resetting Upscaled Image Path
🏁 UPSCAYL
𝌖 BACKEND REPORTED:  🖼️ Updating No Image Processing:  false
𝌖 BACKEND REPORTED:  📐 Updating Compression:  0
𝌖 BACKEND REPORTED:  Is Default Model? :  true
𝌖 BACKEND REPORTED:  ✅ Upscayl Variables:  {"model":"ultramix_balanced","gpuId":null,"saveImageAs":"png","inputDir":"D:\\TEMP\\misc","outputDir":"D:\\TEMP\\misc","fullfileName":"boat1.png","fileName":"boat1","scale":"4","outFile":"D:\\TEMP\\misc\\boat1_upscayl_4x_ultramix_balanced.png","compression":0}
𝌖 BACKEND REPORTED:  📢 Upscayl Command:  -i,D:\TEMP\misc\boat1.png,-o,D:\TEMP\misc\boat1_upscayl_4x_ultramix_balanced.png,-s 4,-m,C:\Program Files\Upscayl\resources\models,-n,ultramix_balanced,-f,png
𝌖 BACKEND REPORTED:  👶 Updating Child Processes:  {"binary":"C:\\Program Files\\Upscayl\\resources\\bin\\upscayl-bin","args":["C:\\Program Files\\Upscayl\\resources\\bin\\upscayl-bin","-i","D:\\TEMP\\misc\\boat1.png","-o","D:\\TEMP\\misc\\boat1_upscayl_4x_ultramix_balanced.png","-s 4","-m","C:\\Program Files\\Upscayl\\resources\\models","-n","ultramix_balanced","-f","png"]}
𝌖 BACKEND REPORTED:  🛑 Updating Stopped:  false
𝌖 BACKEND REPORTED:  image upscayl:  [0 NVIDIA GeForce RTX 3080 Ti]  queueC=2[8]  queueG=0[16]  queueT=1[2]
[0 NVIDIA GeForce RTX 3080 Ti]  bugsbn1=0  bugbilz=0  bugcopc=0  bugihfa=0
[0 NVIDIA GeForce RTX 3080 Ti]  fp16-p/s/a=1/1/1  int8-p/s/a=1/1/1
[0 NVIDIA GeForce RTX 3080 Ti]  subgroup=32  basic=1  vote=1  ballot=1  shuffle=1

🚧 UPSCAYL_PROGRESS:  [0 NVIDIA GeForce RTX 3080 Ti]  queueC=2[8]  queueG=0[16]  queueT=1[2]
[0 NVIDIA GeForce RTX 3080 Ti]  bugsbn1=0  bugbilz=0  bugcopc=0  bugihfa=0
[0 NVIDIA GeForce RTX 3080 Ti]  fp16-p/s/a=1/1/1  int8-p/s/a=1/1/1
[0 NVIDIA GeForce RTX 3080 Ti]  subgroup=32  basic=1  vote=1  ballot=1  shuffle=1

𝌖 BACKEND REPORTED:  image upscayl:  _wfopen C:\Program Files\Upscayl\resources\bin\models/realesrgan-x4plus.param failed

🚧 UPSCAYL_PROGRESS:  _wfopen C:\Program Files\Upscayl\resources\bin\models/realesrgan-x4plus.param failed

𝌖 BACKEND REPORTED:  ❌ INVALID GPU OR FAILED
⚙️ Getting saveImageAs from localStorage:  png
⚙️ Getting model from localStorage:  {"label":"General Photo (Ultramix Balanced)","value":"ultramix_balanced"}
⚙️ Setting gpuId to empty string

xvim64 · Answer 1 · Wed Apr 24 2024 08:05:01 GMT+0800 (China Standard Time)

I have the same issue.

The models folder path is wrong in Windows. (See the log)
Copy the resources/models folder to resources/bin/models.
Howerver, the upscaled output file size is ZERO.

NayamAmarshe · Answer 2 · Wed Apr 24 2024 16:30:27 GMT+0800 (China Standard Time)

Thank you for reporting! We'll fix it

NayamAmarshe · Answer 3 · Wed Apr 24 2024 17:04:49 GMT+0800 (China Standard Time)

Strange,

-m,C:\Program Files\Upscayl\resources\models,-n,ultramix_balanced

The models path is correct here but the backend reads: C:\Program Files\Upscayl\resources\bin\models/realesrgan-x4plus.param for some reason.

NayamAmarshe · Answer 4 · Wed Apr 24 2024 17:05:35 GMT+0800 (China Standard Time)

Could you try changing the models?

xvim64 · Answer 5 · Wed Apr 24 2024 17:49:23 GMT+0800 (China Standard Time)

Could you try changing the models?

I copied 'resources/models' to 'resources/bin/models'.

The outputs of all models are empty. (file size is zero)

I found the reason why the output is empty.
Can you check the -s option in the source code?
On the command line, the -s [number] option is enclosed in quotes, like [“-s 2”], not [-s 2].
If you use [-s 2], the output is OK.

NayamAmarshe · Answer 6 · Wed Apr 24 2024 17:52:49 GMT+0800 (China Standard Time)

Could you try changing the models?

I copied 'resources/models' to 'resources/bin/models'.

The outputs of all models are empty. (file size is zero)

I found the reason why the output is empty. Can you check the -s option in the source code? On the command line, the -s [number] option is enclosed in quotes, like [“-s 2”], not [-s 2]. If you use [-s 2], the output is OK.

Ah good catch! Thanks! I'll have to separate the scale value and the option. Will fix that in 2.11, thank you!

NayamAmarshe · Answer 7 · Wed Apr 24 2024 18:52:07 GMT+0800 (China Standard Time)

@xvim64 Could you please test the latest commit if possible?

xvim64 · Answer 8 · Wed Apr 24 2024 19:16:00 GMT+0800 (China Standard Time)

@xvim64 Could you please test the latest commit if possible?

I can test it.
Where can I get the nightly test build?

NayamAmarshe · Answer 9 · Wed Apr 24 2024 20:48:57 GMT+0800 (China Standard Time)

@xvim64 Could you please test the latest commit if possible?

I can test it. Where can I get the nightly test build?

You'll need to follow the instructions here: https://github.com/upscayl/upscayl?tab=readme-ov-file#-development

xvim64 · Answer 10 · Wed Apr 24 2024 23:29:12 GMT+0800 (China Standard Time)

@NayamAmarshe

You'll need to follow the instructions here: https://github.com/upscayl/upscayl?tab=readme-ov-file#-development

Confirmed fixed.
Now it works well in Windows.