uploadcare / uploadcare-rails

Rails API client that handles uploads and further operations with files by wrapping Uploadcare Upload and REST APIs.

Home Page:https://uploadcare.com

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Rails 5.1 Deprecation Warning

matbrady opened this issue · comments

I'm getting the following warning:

DEPRECATION WARNING: Passing string to define callback is deprecated and will be removed in Rails 5.1 without replacement.

for including:

has_uploadcare_file :file

classic ruby breaking backwards compatibility in minor versions :(

Rails 5.1.0.rc1 throws an ArgumentError now instead of a deprecation warning.

@brandoncordell @matbrady is there a recommended way to address the issue?

@dmitry-mukhin Yes, I'm about to open a pull request for it. I don't know how quickly they'll get to merging it though.

@dmitry-mukhin @matbrady

I've opened a pull request for this.

You can see what's been changed in my branch to make it work so far.

thanks!

commented

@dmitry-mukhin so this is closed, right? Or is it still an issue?

@f6v right, thank you for noticing