Favicon Not Visible in Browser Dark Mode

Question

Favicon Not Visible in Browser Dark Mode

solomonsanderson opened this issue 2 years ago · comments

I have seen issues #3026 and #3545 which mention a new logo, none of these mention the favicon. This appears simply as a circle when using dark mode in chrome.

DVS Dinesh Kumar · Answer 1 · Fri Nov 18 2022 12:03:03 GMT+0800 (China Standard Time)

hey there we need to create two different icons for dark and light mode and we need to use some attributes to use the icons dynamically so that we can appropriate icons for there themes. i would like work on it could please assign this issue for me

ricoz · Answer 2 · Thu Nov 24 2022 05:01:43 GMT+0800 (China Standard Time)

I made some icons:

Home Screen -

Favicon -

c9ssio · Answer 3 · Thu Nov 24 2022 10:45:46 GMT+0800 (China Standard Time)

I just added this new favicon, but why so many favicons with different sizes?

DVS Dinesh Kumar · Answer 4 · Thu Nov 24 2022 10:56:18 GMT+0800 (China Standard Time)

after creating different icons, call this icons in the html page with to different link tags, and then add the media="(prefers-color-scheme: dark)" and media="(prefers-color-scheme: light)"

DVS Dinesh Kumar · Answer 5 · Thu Nov 24 2022 11:07:23 GMT+0800 (China Standard Time)

hey actually the problem is we need to create a new logo for dark mode. the logo should be have #58585A color filled arm and #FFFFFF color of stroke. creating this type of logo the gray fill will be invisible in dark mode and the white stroke in dark mode will be visible as we can see currently a small circle is visible by adding this icon with that attributes mentioned in before comment we can solve this issue

DVS Dinesh Kumar · Answer 6 · Thu Nov 24 2022 22:37:00 GMT+0800 (China Standard Time)

hey you know what i got new simple solution just add the white background to the favicon then it will look good

Solomon Sanderson · Answer 7 · Thu Nov 24 2022 22:43:50 GMT+0800 (China Standard Time)

@dinesh671 Which .html file do you think this should be added to?

add the media="(prefers-color-scheme: dark)" and media="(prefers-color-scheme: light)"

DVS Dinesh Kumar · Answer 8 · Thu Nov 24 2022 23:43:01 GMT+0800 (China Standard Time)

i think in head.html @solomonsanderson

mickey097 · Answer 9 · Thu Nov 24 2022 23:52:48 GMT+0800 (China Standard Time)

On Thu, Nov 24, 2022 at 9:43 AM DVS Dinesh Kumar ***@***.***> wrote: i think in head.html — Reply to this email directly, view it on GitHub <#3611 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/A4BOBAOYTG42UGZ6EEV34XDWJ6EJBANCNFSM6AAAAAASCHJ57Q> . You are receiving this because you are subscribed to this thread.Message ID: ***@***.***>

Yes

neuralpain · Answer 10 · Thu Dec 15 2022 19:35:44 GMT+0800 (China Standard Time)

Is this issue open or closed? If closed then #3026 and #3545 should be closed as well, no?

Ritwik Sharma · Answer 11 · Mon Dec 19 2022 19:34:33 GMT+0800 (China Standard Time)

@solomonsanderson Is this still valid after #3546?

DVS Dinesh Kumar · Answer 12 · Tue Dec 20 2022 15:36:41 GMT+0800 (China Standard Time)

@ritwik12 as you have added the logo that doesn't solved the issue fav-icon is not visible

Kalp Prajapati · Answer 13 · Thu Apr 20 2023 12:36:31 GMT+0800 (China Standard Time)

Hey @dinesh671 can I work on this issue?

DVS Dinesh Kumar · Answer 14 · Thu Apr 20 2023 17:11:39 GMT+0800 (China Standard Time)

hey @munnokd I am not the admin of the group please ask @mickey097 I am also waiting for his reply

Kalp Prajapati · Answer 15 · Fri Apr 21 2023 17:34:18 GMT+0800 (China Standard Time)

@mickey097 Can you assign this issue to me?

MehmetTerc · Answer 16 · Sat May 06 2023 21:51:48 GMT+0800 (China Standard Time)

Can you assign this issue to me?

Diegogonzalez1008 · Answer 17 · Sun Jul 23 2023 18:02:29 GMT+0800 (China Standard Time)

Wtf are we doing explain please

Diegogonzalez1008 · Answer 18 · Sun Jul 23 2023 18:02:45 GMT+0800 (China Standard Time)

I need money

Emor Musk · Answer 19 · Sun Aug 27 2023 17:24:19 GMT+0800 (China Standard Time)

Hello, can this issue be assigned to me

Shashank Pant · Answer 20 · Tue Oct 10 2023 14:25:34 GMT+0800 (China Standard Time)

please assign this to me