charites doesn't respond to favicon.ico requests
pnorman opened this issue · comments
Describe the bug
Browsers will automatically request /favicon.ico from servers sometimes. When this happens, charites doesn't respond, leaving the browser download as pending, causing blocking of other downloads, resulting in the entire page not loading.
$ curl -v http://127.0.0.1:8080/favicon.ico
* Trying 127.0.0.1:8080...
* Connected to 127.0.0.1 (127.0.0.1) port 8080 (#0)
> GET /favicon.ico HTTP/1.1
> Host: 127.0.0.1:8080
> User-Agent: curl/7.74.0
> Accept: */*
>
This never completes.
Expected behavior
favicon.ico returns an empty response, an error, or anything.
Charites Version:
- Charites version: 0.1.4
Desktop (please complete the following information):
- OS: Debian
Looks like f56753a fixes this.
Can we have a new release to get the fix out?
