unixorn / luggage

Project to automate OS X package creation without using the packagemaker GUI

Home Page:https://github.com/unixorn/luggage/wiki

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

modify_packageroot actions get clobbered due to payload being executed twice

twiedenbein opened this issue · comments

In luggage.make, @make modify_packageroot gets called after @make payload in the prep_pkg stanza. However, in the compile_package stanza, 'payload' is listed as a prerequisite, so payload gets made again, and blows away the changes you've made with modify_packageroot. Is this intended behavior?

Also, for what it's worth, removing the payload prerequisite from the compile_package stanza fixes the problem. I'm not sure if that'll break anything else though.

Thanks for the heads up, that's definitely an oversight on my part. Adding make modify_packageroot to the compile_package stanza will force the desired result, I'm updating luggage.make accordingly.