Possible unimplemented functions in JIT's TCP

Question

Possible unimplemented functions in JIT's TCP

kylegoetz opened this issue 2 months ago · comments

Unison TCP base.IO.net.Socket.toText : Socket -> Text exists in Unison Share as a built-in, but the JIT's tcp.rkt does not appear to implement this.

Arya Irani · Answer 1 · Tue Apr 30 2024 11:17:38 GMT+0800 (China Standard Time)

I think it's here; https://github.com/unisonweb/unison/blob/trunk/scheme-libs/racket/unison/primops.ss#L972-L973 @dolio would you confirm?

dolio · Answer 2 · Tue Apr 30 2024 22:52:25 GMT+0800 (China Standard Time)

Yeah, that's the primitive part. Based on that there should also be an auto-generated wrapper in one of the wrapper files.

Was there more indication that it's not working somehow?

kylegoetz · Answer 3 · Fri May 03 2024 06:05:31 GMT+0800 (China Standard Time)

@dolio no indication it's not working. I was just learning by reading the TCP code and noticed I hadn't seen it in the tcp.rkt file. And you're right, it's in simple-wrappers. I had mistakenly assumed the wrong location for the function.