unikraft / ide-vscode

Unikraft Visual Studio Code Extension

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Run and interactive config not working

StefanJum opened this issue · comments

Describe the bug
After installing the extension, using Kraft: Run project and Kraft: Configure project -> interactive does not work.

Steps to reproduce
Initiate the helloworld app and use one of the above commands from the command palette.

Expected behavior
The helloworld app should run or the configuration menu should appear.

Relevant log output

The terminal process "~/.vscode/extensions/unkiraft.kraft-1.0.0/src/scripts/run.sh" failed to launch (exit code: 1).

Render log output:

[renderer1] [trace] terminalInstance#ctor (instanceId: 1) {"name":"kraft run","executable":"/home/stefan/.vscode/extensions/unkiraft.kraft-1.0.0/src/scripts/run.sh","cwd":"/media/stefan/projects/unikraft/test-ide-vsc/kraft-init/init-g","ignoreConfigurationCwd":true,"hideFromUser":false,"extHostTerminalId":"0879577f-f885-4c63-a9c1-8282bb1d9e5a","isExtensionOwnedTerminal":true}
[renderer1] [debug] Terminal process ready (shellProcessId: 436395)
[renderer1] [debug] Terminal process exit (instanceId: 1) with code undefined
[renderer1] [debug] Terminal process exit (instanceId: 1) state 4

Changing the permissions to src/scripts/run.sh and src/scripts/configure.sh seems to solve the issue with Kraft: Run project.
When trying to interactively configure the app, the kraft menuconfig runs without errors but the terminal closes before being able to modify the configuration.

Apparently the problem with the Kraft: Configure project -> interactive command was that the vscode terminal was not big enough for the menuconfig to run.
The error was shown and immediately disappeared so it was very hard to see.

Your display is too small to run Menuconfig!
It must be at least 19 lines by 80 columns.

Simply resizing the vscode terminal window solved the problem for me.

We should add a note in the README.md file to specify the minimum required dimensions for the menuconfig to work.