unifi-utilities / unifios-utilities

A collection of enhancements for UnifiOS based devices

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Documentation: Please update curl commands in nspawn-container article

lwbt opened this issue · comments

commented

Describe the bug
Please update curl commands in nspawn-container article, after reading it once more and comparing the scripts I found a few differences because the other repo is a few commits behind.

To Reproduce
Steps to reproduce the behavior:

  1. Go to https://github.com/unifi-utilities/unifios-utilities/tree/main/nspawn-container
  2. Check "Step 2A: Configure the Container to use an Isolated MacVLAN Network" and compare links in text and code block
  3. Scroll down to "Step 3: Configure Persistence Across Firmware Updates" and compare links in text and code block
  4. A repository peacey/unifios-utilities is used instead of unifi-utilities/unifios-utilities

Expected behavior

  • The links should be the same.
  • No content outside this repo should be fetched with curl without telling the reader about it.

Additional context

  • It could be a potential security issue in the future, but that's a bit far fetched, lets just say things should work as they are intended to be.
-curl -LO https://raw.githubusercontent.com/peacey/unifios-utilities/nspawn/nspawn-container/scripts/10-setup-network.sh
+curl -LO https://raw.githubusercontent.com/unifi-utilities/unifios-utilities/nspawn/nspawn-container/scripts/10-setup-network.sh
-curl -LO https://raw.githubusercontent.com/peacey/unifios-utilities/nspawn/nspawn-container/scripts/0-setup-system.sh
+curl -LO https://raw.githubusercontent.com/unifi-utilities/unifios-utilities/nspawn/nspawn-container/scripts/0-setup-system.sh

Send a PR plz

I fixed it because of security issues