unicodeveloper / laravel-password

:closed_lock_with_key: :smiling_imp: Guard your users against entering dumb passwords in your Laravel 5 apps

Home Page:http://goodheads.io/2016/07/03/introducing-laravel-password-v1-0/

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

refactor

Shaun2D2 opened this issue · comments

commented

Hi @unicodeveloper

I want to contribute to this project a bit more to get my feet wet with open source projects and seems like this one is the perfect starting point for me. I'm thinking we can do a refactor on this to separate the logic for parsing and searching the file to it's own class. What do you think? Overkill? Also was looking at maybe writing out some tests.

Just wanting feedback before I start working on it :)

Thanks,
Shaun

Yes, Sure you can. Feel free to go ahead and do it!. I'll create some issues and labels and assign you to them.