Implement keyboard focus (enhancement)

[Briseur]

The suggestion was previously made on Haiku forum in this thread. Here is a more detailed version.

Actually keyboard navigation is difficult with Flat ControlLook because it misses keyboard focus visuals.
See here for comparison with other ControlLook.

I tried different mock ups to see what could be done.

First, I tried to see if other CL solutions could fit with Flat

• Add a border of navigation colour to the button with keyboard focus like does default Haiku CL.
  Flat CL buttons are slightly rounded so it would be difficult/impossible to implement or won't look good.

• Underline the text of the button with keyboard focus of navigation colour as the Be CL does.
  Use of navigation colour makes it more consistent but even with all buttons of the same size, IMHO it breaks the neat style.
  

As it wasn't convincing enough, I tried to explore other solutions.

• Keep bigger button for the default button and but we are using colour for keyboard focus.
  It looks good but this is not consistent with what other CL are doing and it's somehow a bit confusing.
  

• Add a dot of navigation colour as I suggested on the forum here.
  It is consistent and doesn't break the style.
  

• Same one but with all buttons all of the same size. Would it ease dot positioning?
  IMHO, this even looks better.
  

[Briseur]

Keyboard focus is lacking for buttons, but also for list menus (i.e. Appearance colour list) and drop down menus (i.e. Appearance Decorator & ControlLook menus).
In case of list menus, I suggest to use the some border of navigation colour as in other CL.
For drop down menu widgets, since they are slightly rounded, I suggest to use a dot of navigation colours in bottom right like for buttons.
I may have miss something but in other places, tabs, text fields, boxes, etc the keyboard focus seems working.

[Briseur]

So I made new mock ups to illustrate previous post.

This is what I suggest for list menus. Exactly what is done in other CL.

This is what I had in mind for drop down menus, consistent with what I suggested already for buttons.

This is an alternative suggestion for drop down menus.

I tried to move the dot above or under the arrow but, it wasn't looking good. So, I put the colour on the arrow itself.

I hope that these mock ups would help to implement keyboard focus where it is lacking. Though as l'm not a developer myself, I have no idea if some of the suggestions are feasible or not.

On a side note, I noticed that in Qt apps, default button is (sometimes?) loosing its border. Perhaps having all buttons of same size would help with that...

[nhtello]

Focus its now implemented like defaultcontronlook does. Default button now take the same size like other buttons.