umco / umbraco-vorto

1:1 multilingual property editor wrapper for Umbraco

Home Page:https://our.umbraco.org/projects/backoffice-extensions/vorto

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Vorto failed to convert db value when vorto does not have the DtdGuid

rasmuseeg opened this issue · comments

When setting propertyvalue to VortoValue with empty DtdGuid, getting vorto value from frontend breaks. Why is the DtdGuid even required, shouldn't vorto resolve this from the prevalue collection?

Because at some point in the code chain there is a point at which the property editor has no context when abiding by the public methods in Umbraco so we have to stash the GUID at a point we do know it so we can access it later on.

As mentioned, this is required due to an issue in the umbraco api points so is not a bug. If you are setting the VortoValue manually, you'll have to set the DtdGuid

Wouldn't it make ideal fallback on Umbraco.Textarea or Umbraco.Textstring?

I'd need to think through the whole model and check the code that uses it to see if it would be a problem, unfortunately I'm really low on time atm so it's gonna be pretty low priority.

Feel free to test / PR if you like and I can review what you come up with.