Please update to angular v10 (v11 since 2020-11-11)

Question

Please update to angular v10 (v11 since 2020-11-11)

BruneXX opened this issue 4 years ago · comments

BruneXX commented 4 years ago

Hi guys is there a chance that you can update this to angular v10 ?

Javier Arocena · Answer 1 · Mon Nov 23 2020 06:54:05 GMT+0800 (China Standard Time)

Same here... 😞

sedrak1987 · Answer 2 · Sat Dec 05 2020 23:09:15 GMT+0800 (China Standard Time)

pls update for angular 11

BruneXX · Answer 3 · Fri Dec 11 2020 22:14:23 GMT+0800 (China Standard Time)

Hi Guys any update on this? how can I assist on this? Please just let me know :)

Rajendra · Answer 4 · Sat Dec 19 2020 19:08:48 GMT+0800 (China Standard Time)

I tried following in ng 11:

git clone https://github.com/ultrasonicsoft/ng-connection-service.git
cd ng-connection-service
npm i --save-dev @angular-devkit/build-angular
npm i --save-dev @angular-devkit/build-ng-packagr
npm run build_lib

This will generate ng-connection-service in dist folder.
you can copy this folder in node-module folder and try using this service as mentioned in read me.
you can also try installing the local folder with npm install ../ng-connection-service

Note: don't forget to copy ping.json to your asset folder

It worked for me in Angular 11

BruneXX · Answer 5 · Sat Dec 19 2020 19:19:27 GMT+0800 (China Standard Time)

Hi @bkrajendra thanks, but I don’t want to do that, I just want this component updated, I think that I’ll fork and add support for ng11 by myself. Because I’ve reported this some time ago and I don’t know if this repo is still mantained..

Javier Arocena · Answer 6 · Tue Dec 22 2020 05:59:17 GMT+0800 (China Standard Time)

An updated ng11 suported fork could be awesome

BruneXX · Answer 7 · Tue Dec 29 2020 22:55:23 GMT+0800 (China Standard Time)

Ok, I'll make a fork and update this as soon as I can, I'll share the link here when it's done.

BruneXX · Answer 8 · Wed Dec 30 2020 01:14:29 GMT+0800 (China Standard Time)

I've not tested it yet, but here it is: https://www.npmjs.com/package/ngxc-connection-service should support ng11 now.

Javier Arocena · Answer 9 · Thu Dec 31 2020 08:40:40 GMT+0800 (China Standard Time)

Hi @BruneXX , I tested your fork and get this error:

ERROR Error: Uncaught (in promise): Error: This constructor was not compatible with Dependency Injection.
Error: This constructor was not compatible with Dependency Injection.

I just replaced:
import { ConnectionService } from 'ng-connection-service';

With
import { ConnectionService } from 'ngxc-connection-service';

Any ideas? Thanks!

BruneXX · Answer 10 · Mon Jan 04 2021 23:28:07 GMT+0800 (China Standard Time)

Hi @javierarocena I'll take a look as soon as I can, I was a bit busy these days and I had no time to test it, I'll took a look soon, thanks for your comment :)

ElCarsten · Answer 11 · Thu Dec 23 2021 00:17:53 GMT+0800 (China Standard Time)

@javierarocena You need to update the package by this command npm install ngxc-connection-service --save first

oussema · Answer 12 · Sat Jan 22 2022 16:50:05 GMT+0800 (China Standard Time)

Hi, I just installed this library to know the status of my connection status, but when I make the import to my online service it tells me
Could not find a declaration file for module 'ngxc-connection-service'
how i can fix this issue?