Giters

ukaea / PROCESS

PROCESS is a systems code at UKAEA that calculates in a self-consistent manner the parameters of a fusion power plant with a specified performance, ensuring that its operating limits are not violated, and with the option to optimise to a given function of these parameters.

Home Page:https://ukaea.github.io/PROCESS/

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Incorrect error in winding pack current density constraint.

ajpearcey opened this issue · comments

commented

In constraint 35 for the current density in the winding pack the constraint error is calculated as

tmp_err = jwptf - jwptf

This is wrong and surely causes the constraint to never be violated? I believe it should be

tmp_err =  jwptf - jwdgpro
commented

In this output, for example, the reported error is zero, but the normalised residue is not, because it is printing a different variable which is correct:

                                               physical                 constraint                 normalised
                                              constraint                 residue                    residue
   17  J_winding pack/J_protection limit     <  2.5694E+07 A/m2         0.0000E+00 A/m2           -2.9894E-07

Note that I think tmp_err is only used in the output table, not in the rest of the code, so this error doesn't affect the results.