Does not follow Github theme
kozross opened this issue · comments
If I have an inclusion like below in a Github wiki page:

I get this on a Github light theme:
But it works fine on a dark one:
I can forcibly set the text colour, but this feels like a bug, plus there isn't really a good choice of colour that would work on both light and dark themes.
Is your system theme in dark mode?
Hmm what should we do? Basically two options
- Ditch automatic color switching & add background
- Grey color as a default
Being able to force a background colour would fix this issue for me.
Just found this option in GitHub docs. Maybe we can also offer more fine-grained Markdown tags for GitHub users in the online editor.
https://docs.github.com/en/get-started/writing-on-github/getting-started-with-writing-and-formatting-on-github/basic-writing-and-formatting-syntax#specifying-the-theme-an-image-is-shown-to


^Maybe this only works in actual Markdown files?
Turned out this trick doesn't play nice with .svg 🤷♂️
https://github.community/t/support-theme-context-for-images-in-light-vs-dark-mode/147981/96
This also doesn't work on Github wiki pages.
Released