Username in bottom right corner is not properly filtered
PatheticMustan opened this issue · comments
Describe the bug
See title
To Reproduce
Steps to reproduce the behavior:
- Log in with a username like
<b>test</b>
- Look towards the bottom right corner
Screenshots
If applicable, add screenshots to help explain your problem.
Additional context
Add any other context about the problem here.
A simple one line fix, just add filtering here
Line 65 in 1a55ec9
@PatheticMustan This is only possible if you're admin, as usually you're username has to go through DOMpurify otherwise.
no.... if you just look at the line I linked, it doesn't put anything through DOMpurify
I haven't looked at if the admin or other users can view this, but I would guess not.
it's just a minor issue, but i thought i should point it out
Na, because it's in chat.js. If the client managed to get to chat.js, (got past join.js), it means that the username has already been filtered by the server.