udemy / eslint-plugin-gettext

gettext linting rules for ESLint

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Fork status

jayvdb opened this issue · comments

Is this a long lived fork? I've raised a few issues in the main repo , and intend to work on them, so could just as easily do them here as this project seems a bit more active.

The README "Installation" is wrong for this repo if it is to be a permanent fork.

It would be nice to try to submit the new rule back to https://github.com/appannie/eslint-plugin-gettext

Hey @jayvdb this is actively maintained, but it looks like we've committed some changes that are kind of unique to our code - #1 and #2 which probably shouldn't be in the "main" version of this library 🤔

This new rule however is quite generic #6 and could be useful in the main repo. Would you like me to raise this PR into the appannie version? Or you can go ahead as well, I don't mind :)

It would be great if you could raise a PR for #6 upstream.

You may also be interested in helping with design of two features I've raised at https://github.com/appannie/eslint-plugin-gettext/issues , and I've done a hacking implementation of one of them which needs experienced eyes.