ucsd-ccbb / qiimp

Web application to collect metadata specifications from an experimenter and produce metadata input files with appropriate constraints

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Improve max/min validation to give more meaningful message if type failure

AmandaBirmingham opened this issue · comments

If a maximum is filled in with an invalid data type (e.g., 2007-12, which is a date, when the data type is set to decimal), the maximum-is-greater-than-minimum validation fails. This in itself is ok, but the message it returns misidentifies the problem; the issue is not that the maximum is less than the minimum, but that the max, the min, or both, is not the right data type (see image below). Improve the messaging.

screen shot 2018-09-20 at 10 21 49 am

Maybe this is a low-hanging fruit task for @charles-cowart to start digging into the code here?