GS45 theme review
Jupi007 opened this issue · comments
I create this issue to track the problems and todo things of the GS theme.
Wrong focus ring color - fixed by #3989
Quick toggles are "eye burning"
Revert top bar to upstream size - fixed by #3990
Light theme inputs background is weird - fixed by #3994
Sound volume slider thumb border is cropped - fixed by #3992
BTW the track color isn't use the correct color shade, it looks toned down - fixed by #3993
I think also the inner border-radii of elements inside the shell popups were also too large compared to our yaru outer radius of the popups
One more.... :)
The extensions page on looking-glass is broken when using the light theme.
One more.... :)
The extensions page on looking-glass is broken when using the light theme.
Classic! I don't know how often we've been to looking glass xD
Hi all,
[Noble]
Bad switches circle alignment.
Bad selection alignment (here Firefox)
(here Nautilus)
@fthx Thanks for your comment.
On your first and last screenshots, the app is using Libadwaita, so we have no control over the theming.
But to be honest, I can't notice what is the problem for each of your screenshot 😅
Also, this issue is related to the Gnome Shell theme and not the Gtk one 🙂
Btw, I think we can close this issue.
Mmmh. Ok if I have to request this through GS gitlab or whatever, but there IS a problem. ;-)
First one. Here I use Noble with GNOME/Adwaita.
The white circle in switch blue button is not very well centered but better than Yaru's orange one.
Second one. Firefox then Nautilus.
The blue selection is centered, the / is not touching the border. That's not the case using Yaru.
firefox uses their own way to look up our theme, but it is def. not gtk4 as nautilus. we did not claim to have 100% visual parity with gtk3 and gtk4. gtk3 is untouched since many releases to not create issues and gtk4 comes almost directly from upstream
some things come from gtk3 as far as I remember
the orange and the white thing could be an optical illusion. white inside bright orange is always problematic
Also, you are using a different font on your screenshots with Adwaita, Cantarell I suppose.
The "y" letter is clearly longer and the "/" is shorter, using Cantarell compared to the Ubuntu font.
Yes I did remove my glasses and came very near by my screen and you're right, that's an optical illusion for both orange and blue. But I see it much less in blue.
For the selection too, you're right, GNOME session did not use my previous Ubuntu font!!
My bad.
So first one no issue.
Second one maybe Ubuntu fonts issue.
Also, you can see that the switch thumb is equidistant to each edge of 2px 🙂
Yes that's what I saw at 2cm of my 27 inches screen :-).