ubient / laravel-vapor-action

Run Laravel Vapor commands directly from Github Actions

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

sh: docker: not found error with Docker image

rocketkev opened this issue · comments

I followed the docker image example exactly. But receiving sh:docker:not found error:

==> Building Container Image
sh: docker: not found

In Process.php line 267:
                                                                               
  [Symfony\Component\Process\Exception\ProcessFailedException]                 
  The command "docker build --pull --file=production.Dockerfile --tag=project:produdction ."   
  failed.                                                                      
                                                                               
  Exit Code: 127(Command not found)                                            
                                                                               
  Working directory: /app/.vapor/build/app                                     
                                                                               
  Output:                                                                      
  ================                                                             
                                                                               
                                                                               
  Error Output:                                                                
  ================                                                             
  sh: docker: not found                             

Hi!

Unfortunately, the Docker container build by itself doesn't support docker 'recursively', and given the purpose of this project I don't think that I'd want to support it either going forward, as it significantly increases the image size (which is re-downloaded on every single deployment in everyone's projects)

Given your needs, I'd instead recommend you to use the 'advanced' approach (as documented in the readme), as it's a lot more flexible, configurable and even faster. If I'm being honest, I'd pretty much recommend everyone to start migrating to/start using that instead these days, as the Github Actions landscape has improved significantly ever since this action was initially created:

image

Hope this helps!