concat back widget & datasource from mixins
topliceanu opened this issue · comments
Makes development a pain because degugging is hard (chrome debugger won't jump into a function from a mixin).
I'm with @topliceanu on this one. I get that the widget and datasource modules were too bloated, but it seemed like a rash solution. I think we can clean up the code by having more superclasses and re-usable libs (as opposed to a few nested mixins). If I were to draw a line I'd say one of the biggest problems is that you have a method call in one place for a method defined in another, this doesn't meet neither the require.js pattern nor a healthy encapsulated mixin one.
Guys,
The purpose of the break-down was to start splitting stuff into classes
afterwards. I don't think it's a good idea to go back - let's write more
tests and start refactoring it with classes in 1-2 months.
Ok, I wasn't aware it was a two-step plan :)
On Thu, Jan 17, 2013 at 6:32 PM, Andrei-Adnan Ismail <
notifications@github.com> wrote:
Guys,
The purpose of the break-down was to start splitting stuff into classes
afterwards. I don't think it's a good idea to go back - let's write more
tests and start refactoring it with classes in 1-2 months.—
Reply to this email directly or view it on GitHubhttps://github.com//issues/49#issuecomment-12375797.
Best regards,
Ovidiu Cherecheş