uber / react-digraph

A library for creating directed graph editors

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

SelectionT should have edges defined as Map<string, IEdge>, not Map<string, INode>

ElleFioLange opened this issue Β· comments

Hi! πŸ‘‹

Firstly, thanks for your work on this project! πŸ™‚

Today I used patch-package to patch react-digraph@8.0.0-beta.6 for the project I'm working on.

The type definition for SelectionT has edges listed as Map<string, INode> | null, when it should instead be Map<string, IEdge> | null.

Here is the diff that solved my problem:

diff --git a/node_modules/react-digraph/typings/index.d.ts b/node_modules/react-digraph/typings/index.d.ts
index 6b8a616..172e4ac 100644
--- a/node_modules/react-digraph/typings/index.d.ts
+++ b/node_modules/react-digraph/typings/index.d.ts
@@ -96,7 +96,7 @@ declare module 'react-digraph' {
 
   export type SelectionT = { 
     nodes: Map<string, INode> | null, 
-    edges: Map<string, INode> | null 
+    edges: Map<string, IEdge> | null 
   };
 
   export const Edge: React.Component<IEdgeProps>;

This issue body was partially generated by patch-package.

The master branch has fixed this issue via #317. I will release the new version shortly (likely 8.0.0 final). Thank you for opening this issue.