Race in Register...WithOptions due to un-protected map read

[Steven L]

cadence-client/internal/internal_worker.go

Line 557 in 451db6c

 if _, ok := r.workflowFuncMap[registerName]; ok { 

It's pretty clear when the addWorkflowFn call right below it uses a mutex:

cadence-client/internal/internal_worker.go

Lines 664 to 668 in 451db6c

 func (r *registry) addWorkflowFn(fnName string, wf interface{}) { 
 	r.Lock() 
 	defer r.Unlock() 
 	r.workflowFuncMap[fnName] = wf 
 } 

This is also happening in the equivalent Activity methods:

cadence-client/internal/internal_worker.go

Line 598 in 451db6c

 if _, ok := r.activityFuncMap[registerName]; ok { 

vs

cadence-client/internal/internal_worker.go

Lines 712 to 716 in 451db6c

 func (r *registry) addActivity(fnName string, a activity) { 
 	r.Lock() 
 	defer r.Unlock() 
 	r.activityFuncMap[fnName] = a 
 } 

Can I request adding more t.Parallel() tests to catch this kind of thing up-front?