uber-go / cadence-client

Framework for authoring workflows and activities running on top of the Cadence orchestration engine.

Home Page:https://cadenceworkflow.io

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Add rpc request metrics with retry in consideration

meiliang86 opened this issue · comments

Is your feature request related to a problem? Please describe.
Right now we have rpc metrics for single requests that does not factor in retry options. Since client does retries automatically, this does not tell the accurate story about the actual failure rate.

Proposed Solution
Add metrics after all the retry attempts are exhausted. We can start with sync APIs (start/signal/signalWithStart), and maybe implement this for all if that's not messing up the code too much.

@meiliang86 I didn't understand the purposed solution. As we have backoff retry, shouldn't these retries still be counted in the failure rate? Do you mean that we should only count this as one failure after there is context timeout?