.f isn't scoped to the componet

Question

.f isn't scoped to the componet

VizualAbstract opened this issue 4 years ago · comments

Corey Matthew Capetillo commented 4 years ago

Any element with the class of .f is being styled by the styles in this component.

In our application, our customers are allowed to create or provide supplemental HTML, and some customers use 'f' as a class. This is causing many of their UIR elements to appear broken.

Ubaldo Pescatore · Answer 1 · Wed Apr 29 2020 16:08:12 GMT+0800 (China Standard Time)

Hi @VizualAbstract, thanks for pointing out the issue. Would '.flag' be ok instead?

Corey Matthew Capetillo · Answer 2 · Thu Apr 30 2020 00:04:59 GMT+0800 (China Standard Time)

I think so! @p3trur0

I know for my team, I always recommend we prefix our classes. Our company's initicals are rc, so I use .rc_, but that's just our preference. Either way, .flag would be a great upgrade

Ubaldo Pescatore · Answer 3 · Thu Apr 30 2020 16:43:16 GMT+0800 (China Standard Time)

Cool! I think I'll some spare time to work on it tomorrow. Otherwise, if you are in a rush, please consider to do it by yourself and open a PR :)

Ubaldo Pescatore · Answer 4 · Fri May 01 2020 15:31:59 GMT+0800 (China Standard Time)

Hi @VizualAbstract, please check out version 2.0.1. As suggested, the main CSS class of the component has been renamed to flag. Hope it helps to solve your issue.