Use same version of uap-core for Python and Scala versions of UA parser

Question

ptkool opened this issue 7 years ago · comments

The Python and Scala versions of the parser are using different commits of uap-core. Can we synch them up to reference the same commit? @mattrobenolt

Matt Robenolt · Answer 1 · Fri Dec 02 2016 04:47:43 GMT+0800 (China Standard Time)

I periodically keep uap-python up to date. I don't keep them religiously in sync though. Not sure what you're asking me here. :)

Michael Styles · Answer 2 · Fri Dec 02 2016 08:23:38 GMT+0800 (China Standard Time)

We are currently using both uap-python and uap-scala and require that they both reference the same uap-core SHA.

Would it be possible to update uap-scala?

Ahmed Kamel · Answer 3 · Mon Dec 05 2016 17:52:09 GMT+0800 (China Standard Time)

I've updated to the latest uap-core in this commit.

Michael Styles · Answer 4 · Mon Dec 05 2016 18:11:28 GMT+0800 (China Standard Time)

@humanzz Can you up update uap-core for uap-python to the same commit?

Ahmed Kamel · Answer 5 · Mon Dec 05 2016 19:41:06 GMT+0800 (China Standard Time)

I'm afraid I only have permissions to uap-scala and not uap-python. One of its maintainers have to do that.

Matt Robenolt · Answer 6 · Tue Dec 06 2016 00:26:13 GMT+0800 (China Standard Time)

I'm not gonna lie, assuming that all libraries always use the same sha of uap-core is not really going to be feasible.

Fortunately though, there's nothing requiring this to happen in at least uap-python. You can supply your own list. Just set the UA_PARSER_YAML environment variable: https://github.com/ua-parser/uap-python/blob/master/ua_parser/user_agent_parser.py#L450 and you're free to maintain your own explicit sha of uap-core independent of releases.