Giters

ua-parser / uap-csharp

C# implementation of ua-parser

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Latest uap-core updates cause tests to fail

NeilP-global opened this issue · comments

commented

This is really odd, as it appears that uap-core is passing.

Maybe I'm doing something really dumb, but it would be so helpful if someone could check if it's just a problem with my own environment.

Using VS2017 and the latest version of uap-csharp and uap-core.

  Failed tests:
  testcase 237: Major did not match. (expected:NT actual:$1)  in Mozilla/5.0 (Windows U; Win NT 5.0; en-US; rv:1.8.0.2) Gecko/20060308 Firefox/1.5.0.2
  testcase 238: Major did not match. (expected:NT actual:$1)  in Mozilla/5.0 (Windows; N; WinNT; en-US; m14) Netscape6/6.0b1,gzip(gfe),gzip(gfe),gzip(gfe)
  testcase 242: Major did not match. (expected:3.1 actual:$1)  in Mozilla/5.0 (Windows; U; Win3.1; en-US; rv:1.0.0) Gecko/20020530
  testcase 243: Major did not match. (expected:3.1 actual:$1)  in Mozilla/5.0 (Windows; U; Win3.11; en-US; rv:21.56.11.90) Gecko/20500230 Firefox/3.5
  testcase 245: Major did not match. (expected:95 actual:$1)  in Mozilla/5.0 (Windows; U; Win95; en-GB; rv:1.0.1) Gecko/20020823 Netscape/7.0
  testcase 246: Major did not match. (expected:95 actual:$1)  in Mozilla/5.0 (Windows; U; Win95; en-GB; rv:1.8.0.8) Gecko/20061025 Firefox/1.5.0.8
  testcase 340: Major did not match. (expected:8.1 actual:$1)  in Box Sync/4.0.7848;Windows/8.1;x86 Family 6 Model 158 Stepping 9, GenuineIntel/32bit
  testcase 341: Major did not match. (expected:10 actual:$1)  in Box Sync/4.0.7848;Windows/10;Intel64 Family 6 Model 158 Stepping 9, GenuineIntel/64bit
  testcase 344: Major did not match. (expected:10 actual:$1)  in Box/1.2.93;Windows/10;Intel64 Family 6 Model 158 Stepping 9, GenuineIntel/64bit
commented

In fairness, this does feel more like a bug to be raised against the uap-core project, if I'm right, then their changes have broken everything downstream.

Feels like an issue with either the new regexes.yaml file or the updates test cases.

commented

can a build be triggered to confirm this? (assuming the build process updates the submodules) the last build on your build server was before the change to the uap-core file was made

commented

Should be fixed now....finally. Apologies