ua-parser / uap-core

The regex file necessary to build language ports of Browserscope's user agent parser.

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Test issue with latest regexes

pseverino opened this issue · comments

I did a pull for the latest data and it looks like the project's tests are failing with it:

` 31933 passing (9s)
2 failing

  1. ../tests/test_ua.yaml
    Twitterbot/1.0:

    AssertionError [ERR_ASSERTION]: Expected ua.family to be "TwitterBot" got "Twitterbot" instead.

    • expected - actual

    -Twitterbot
    +TwitterBot

    at Context. (tests/test.js:25:16)
    at processImmediate (internal/timers.js:439:21)

  2. ../test_resources/pgts_browser_list.yaml
    fetch libfetch/2.0:

    AssertionError [ERR_ASSERTION]: Expected ua.family to be "Other" got "fetch libfetch" instead.

    • expected - actual

    -fetch libfetch
    +Other

    at Context. (tests/test.js:25:16)
    at processImmediate (internal/timers.js:439:21)`

@pseverino travis says tests are fine. Could you please check at your side?

You're right, after searching thought a bunch of logs I found out that the tests that were created internally by us with your tests weren't actually getting updated.

A simple case of docker cache, thanks for checking and sorry for the trouble