regeneratorRuntime is not defined
jonathanmtran opened this issue · comments
Describe the bug
A regeneratorRuntime is not defined is preventing the modal notification from rendering
To Reproduce
- Deploy portlet with a modal notification web component such as uPortal-Project/uPortal-start#226
- Open developer tools
- Navigate to the page containing the modal notification web component
Expected behavior
A notification modal
Screenshots
Platform:
- Notification Portlet Version: 4.3.1
- Browser: Chrome/ium and Firefox
Looking into this now 🔍
@jonathanmtran a work around is adding <script src="https://unpkg.com/regenerator-runtime@0.12.1/runtime.js"></script>
uPortal-Project/uPortal-web-components#117 will probably be the long term fix to prevent this from coming up again as new components get added.
Adding <script src="https://unpkg.com/regenerator-runtime@0.12.1/runtime.js"></script> works for Chrome/ium
On the other hand, the modal doesn't render on Firefox
What version of notification are you using?
That should have been fixed when https://github.com/Jasig/NotificationPortlet/blob/e673a002469ecb3179afcf7eb3692814520e555d/notification-portlet-webcomponents/notification-modal/src/components/NotificationModal.vue#L179-L183
was added in dcd0f11, included in v4.3.1+
Is it still happening in 4.3.1 on your system?
@ChristianMurphy Yes. I've deployed 4.3.1 and it still doesn't render/appear on Firefox
@jonathanmtran I tested this with uPortal 5.3.0 and a snapshot of the master branch of this repo (soon to be officially released).
I'm seeing it work on Chrome, Firefox, and Edge.
Let me know if you run into any other issues, we could hop on a video call and debug.
Notification portlet 4.4.0 includes the fixes