instanceof will always return false in getParent(Object), since a org.eclipse.pde.internal.runtime.registry.model.ModelObject can't be a org.eclipse.pde.internal.runtime.registry.model.Folder in RegistryBrowserContentProvider.java

[Google Code Exporter]

Bug report generated from FindBugs
instanceof will always return false in getParent(Object), since a 
org.eclipse.pde.internal.runtime.registry.model.ModelObject can't be a 
org.eclipse.pde.internal.runtime.registry.model.Folder

In class 
org.eclipse.pde.internal.runtime.registry.RegistryBrowserContentProvider
  In method getParent(Object)
  Actual type org.eclipse.pde.internal.runtime.registry.model.ModelObject
  Expected org.eclipse.pde.internal.runtime.registry.model.Folder
  Value loaded from element
  At RegistryBrowserContentProvider.java:[line 150]

Relevant source code:
  146:   if (!(element instanceof ModelObject)) {
  147:      return null;
  148:   }
  149: 
  150:   if (element instanceof Folder) {
  151:      return ((Folder) element).getParent();
  152:   }

Bug pattern explanation:
This instanceof test will always return false. Although this is safe, make 
sure it isn't an indication of some misunderstanding or some other logic error.



FindBugs issue identifier (do not modify or remove): 
9e4d5c508219591c50874d236336d24f

Original issue reported on code.google.com by keithl on 17 Feb 2010 at 2:44

[Google Code Exporter]

Original comment by keithl on 17 Feb 2010 at 3:05

• Changed state: Invalid